p-interface: Fix try_from for TokenInstruction #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
reviewed
Jan 8, 2026
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Good catch! Since #118 is already fixing the try_from implementation, could you please update this PR to only add tests for the p-interface? We can follow the same pattern as interface:test:
- have a script for it on
package.json - run the "new"
p-interface:testthe format_and_lint_ptoken step in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The enum variant
UnwrapLamports = 45is not present in thetry_fromfunction for theTokenInstructionof the p-interface.Solution
Add
45to the match branch. Also, add p-interface tests to CI to catch such errors in the future.